-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #5549 Clear cache table on domain change #6696
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Aside the comment above, On develop, I can see that we clear the cache table during domain change but it's not truncated, with this PR we truncate the cache table. I also proactively ran smoke tests on e2e and it passes. @MathieuLamiot do we wait for a test plan from @wp-media/qa-team on this one. |
@jeawhanlee @Tabrisrp Unless you see something risky in the changes, let's not wait for a specific test plan. Instead we should:
|
Following @jeawhanlee comments on the review, I am moving this back to In Progress so that you can discuss them. |
Working as expected according to AC here |
Description
Fixes #5549
Documentation
User documentation
Technical documentation
Type of change
Checklists
Feature validation
Code style