Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback value for src attribute if not set #6700

Merged
merged 7 commits into from
Jun 6, 2024
Merged

Fallback value for src attribute if not set #6700

merged 7 commits into from
Jun 6, 2024

Commits on Jun 5, 2024

  1. Remove duplicated code 

    Fallback value for src attribute if not set
    @MathieuLamiot
    MathieuLamiot committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    c2ec494 View commit details
    Browse the repository at this point in the history

  2. Fix linter

    @MathieuLamiot
    MathieuLamiot committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    67ab4ef View commit details
    Browse the repository at this point in the history

  3. Fix tests: when bg_set exists, src must be an empty string

    @MathieuLamiot
    MathieuLamiot committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    7d65045 View commit details
    Browse the repository at this point in the history

  4. Fix order of json attributes in expected results

    @MathieuLamiot
    MathieuLamiot committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    781bd6b View commit details
    Browse the repository at this point in the history

  5. Fix json message for tests

    @MathieuLamiot
    MathieuLamiot committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    64ea5d2 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Adjusted comment based on feedback

    @MathieuLamiot
    MathieuLamiot committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    437d418 View commit details
    Browse the repository at this point in the history

  2. Linter fix :D - Never let a manager code, they break stuff all the time!

    @MathieuLamiot
    MathieuLamiot committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7cc4788 View commit details
    Browse the repository at this point in the history