TEST ONLY DO NOT MERGE Fix/picture src regression

[MathieuLamiot]

TEST ONLY DO NOT MERGE

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 4dd69dd1	✅ 80.00% (target: 50.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (4dd69dd)	Report Missing	Report Missing	Report Missing
Head commit (6026c28)	37269	14461	38.80%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6709)	20	16	80.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

---

_{🚀 Don’t miss a bit, follow what’s new on Codacy.}

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[MathieuLamiot]

CI Passes.
Rocket-E2E passes except:

Expected Viewport for desktop - wp-content/rocket-test-data/images/lcp/testjpg.jpg for http://mathieu.e2e.rocketlabsqa.ovh/lcp_no_dimensions_picture is not present in actual - [{"type":"picture","src":"http://mathieu.e2e.rocketlabsqa.ovh/test.png","sources":[]},{"type":"picture","src":"http://mathieu.e2e.rocketlabsqa.ovh/wp-content/rocket-test-data/images/test3.gif","sources":[{"srcset":"http://mathieu.e2e.rocketlabsqa.ovh/wp-content/rocket-test-data/images/lcp/testwebp.webp","media":"(max-width: 700px)","type":"","sizes":""},{"srcset":"http://mathieu.e2e.rocketlabsqa.ovh/wp-content/rocket-test-data/images/lcp/testjpeg.jpeg","media":"(max-width: 450px)","type":"","sizes":""}]}]

Expected LCP for mobile - /wp-content/rocket-test-data/images/lcp/testsvg.svg for http://mathieu.e2e.rocketlabsqa.ovh/lcp_no_dimension_svg is not present in actual - {"type":"img","src":"https://discuss-assets.s3.amazonaws.com/original/3X/1/9/19823cc1f1f887d70755e0b500dd8ce2c51ba7f9.svg"}


Expected Viewport for mobile - /wp-content/rocket-test-data/images/lcp/testjpg.jpg for http://mathieu.e2e.rocketlabsqa.ovh/lcp_no_dimensions_picture is not present in actual - [{"type":"picture","src":"http://mathieu.e2e.rocketlabsqa.ovh/wp-content/rocket-test-data/images/test3.gif","sources":[{"srcset":"http://mathieu.e2e.rocketlabsqa.ovh/wp-content/rocket-test-data/images/lcp/testwebp.webp","media":"(max-width: 700px)","type":"","sizes":""},{"srcset":"http://mathieu.e2e.rocketlabsqa.ovh/wp-content/rocket-test-data/images/lcp/testjpeg.jpeg","media":"(max-width: 450px)","type":"","sizes":""}]},{"type":"picture","src":"http://mathieu.e2e.rocketlabsqa.ovh/test.png","sources":[]}]

1 & 3: is it expected now to skip testjpg.jpg, the 2nd source in a picture tag, in the ATF images.
2nd is a known issue.

On http://mathieu.e2e.rocketlabsqa.ovh/lcp_no_dimensions_picture/, here are the markups now:

<link rel="preload" as="image" href="http://mathieu.e2e.rocketlabsqa.ovh/wp-content/rocket-test-data/images/lcp/testavif.avif" media="(max-width: 700px)" fetchpriority="high">
<link rel="preload" as="image" href="http://mathieu.e2e.rocketlabsqa.ovh/wp-content/rocket-test-data/images/lcp/testPng.png" media="(min-width: 700.1px) and (max-width: 450px)" fetchpriority="high">
<link rel="preload" as="image" href="http://mathieu.e2e.rocketlabsqa.ovh/wp-content/rocket-test-data/images/lcp/testjpg.jpg" media="(min-width: 450.1px)" fetchpriority="high">