Overwrite .htaccess file after deleting rules even if there is no content

[tkalimullin-coludlinux]

Description

Fixed the process of clearing the .htaccess file in cases where the .htaccess file was empty.

Documentation

User documentation

If during deactivation of the plugin there are no other rules that relate to WordPress, then the WP Rocket rules will not be deleted.

Technical documentation

The fwrite function will not write changes to a file if the $new_file_data variable is empty.
Even though fwrite returns 0, which is not an error, the following condition will not work:

if ( $bytes ) {
 ftruncate( $pointer, ftell( $pointer ) );
}

It is necessary to clearly determine that no error occurred when trying to work with the file, and only in this case do not try to truncate the file:

if ( $bytes !== false ) {
 ftruncate( $pointer, ftell( $pointer ) );
}

Type of change

• Bug fix (non-breaking change which fixes an issue).

Checklists

Code style

• [+] I wrote self-explanatory code about what it does.
• [+] I did not introduce unecessary complexity.

[MathieuLamiot]

CI tests are failing. Moving this back to "Todo" to be investigated.

[Mai-Saad]

Working as expected, if nothing is needed for unit tests, we can merge this
testrail-report-615.pdf