Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPStan on tests #6733

Merged
merged 24 commits into from
Jun 21, 2024
Merged

Add PHPStan on tests #6733

merged 24 commits into from
Jun 21, 2024

Conversation

Tabrisrp
Copy link
Contributor

@Tabrisrp Tabrisrp commented Jun 21, 2024

Description

Extend our current PHPStan coverage (level 0) to the tests files

Documentation

User documentation

This extends the PHPStan action to tests files, so even there the PHP code quality can be checked and validated. In this PR it passed the same level 0 as the main files for now

No impact

Technical documentation

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Checklists

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.

@Tabrisrp Tabrisrp self-assigned this Jun 21, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 1b3b8a51 (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1b3b8a5) Report Missing Report Missing Report Missing
Head commit (9fc9656) 37290 14481 38.83%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6733) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@Tabrisrp Tabrisrp marked this pull request as ready for review June 21, 2024 14:08
@Tabrisrp Tabrisrp requested a review from a team June 21, 2024 14:08
@MathieuLamiot MathieuLamiot added this pull request to the merge queue Jun 21, 2024
Merged via the queue into develop with commit a8da7ae Jun 21, 2024
13 checks passed
@MathieuLamiot MathieuLamiot deleted the enhancement/phpstan-tests branch June 21, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants