-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure to send mobile visit to saas warmup for OCI with a fresh install #6753
Make sure to send mobile visit to saas warmup for OCI with a fresh install #6753
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
For @wp-media/qa-team you can use the following snippet to completely disable mobile cache options to be used to validate the mentioned AC:
|
@wordpressfan A quick feedback, not blocking for the PR but more food for thought, to improve: we would lack integration tests that capture the AC better. Currently, all tests involving |
Totally agree with you @MathieuLamiot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test summary https://wp-media.slack.com/archives/CUT7FLHF1/p1719910569290519?thread_ts=1719832961.594679&cid=CUT7FLHF1 . if newlabs state with a fresh install is considered an edge case and not a priority for now then we can merge with the following notes: |
Description
Fixes #6752
Documentation
User documentation
For fresh installation or when the mobile cache settings are not set, we will consider it active by default.
Technical documentation
Here we set the default value sent to
$this->options->get
to be 1.Type of change
Delete options that are not relevant.
New dependencies
List any new dependencies that are required for this change.
Risks
Can't think of any risk here.
Checklists
Feature validation
Documentation
Code style
Observability
Risks