Closes #6621 Increase phpstan level to level 1

inc/Engine/CDN/RocketCDN/AdminPageSubscriber.php

@@ -86,18 +86,21 @@ public function display_rocketcdn_status() {
 
 		$subscription_data = $this->api_client->get_subscription_data();
 
+		$container_class = '';
+		$status_class    = '';
+		$label           = '';
+		$status_text     = '';
+		$is_active       = false;
+
 		if ( 'running' === $subscription_data['subscription_status'] ) {
-			$label           = __( 'Next Billing Date', 'rocket' );
-			$status_class    = ' wpr-isValid';
-			$container_class = '';
-			$status_text     = date_i18n( get_option( 'date_format' ), strtotime( $subscription_data['subscription_next_date_update'] ) );
-			$is_active       = true;
+			$label        = __( 'Next Billing Date', 'rocket' );
+			$status_class = ' wpr-isValid';
+			$status_text  = date_i18n( get_option( 'date_format' ), strtotime( $subscription_data['subscription_next_date_update'] ) );
+			$is_active    = true;
 		} elseif ( 'cancelled' === $subscription_data['subscription_status'] ) {
-			$label           = '';
 			$status_class    = ' wpr-isInvalid';
 			$container_class = ' wpr-flex--egal';
 			$status_text     = __( 'No Subscription', 'rocket' );
-			$is_active       = false;
 		}
 
 		$data = [

inc/Engine/CDN/RocketCDN/views/cta-big.php

@@ -15,6 +15,8 @@
  */
 
 defined( 'ABSPATH' ) || die( 'Cheatin’ uh?' );
+
+$data = isset( $data ) && is_array( $data ) ? $data : []; // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
 ?>
 <div class="wpr-rocketcdn-cta <?php echo esc_attr( $data['container_class'] ); ?>" id="wpr-rocketcdn-cta">
 	<?php if ( ! empty( $data['promotion_campaign'] ) ) : ?>

inc/Engine/CDN/RocketCDN/views/cta-small.php

@@ -10,6 +10,8 @@
  */
 
 defined( 'ABSPATH' ) || die( 'Cheatin’ uh?' );
+
+$data = isset( $data ) && is_array( $data ) ? $data : []; // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
 ?>
 <div class="wpr-rocketcdn-cta-small notice-alt notice-warning <?php echo esc_attr( $data['container_class'] ); ?>" id="wpr-rocketcdn-cta-small">
 	<div class="wpr-flex">

inc/Engine/CDN/RocketCDN/views/dashboard-status.php

@@ -14,6 +14,7 @@
  * }
  */
 
+$data = isset( $data ) && is_array( $data ) ? $data : []; // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
 ?>
 <div class="wpr-optionHeader">
 	<h3 class="wpr-title2">RocketCDN</h3>

inc/Engine/Common/Database/Queries/AbstractQuery.php

@@ -511,7 +511,7 @@ protected function table_exists(): bool {
 		$db = $this->get_db();
 
 		// Bail if no database interface is available.
-		if ( empty( $db ) ) {
+		if ( ! $db ) {
 			return false;
 		}
 

inc/Engine/Common/Database/Tables/AbstractTable.php

@@ -49,7 +49,7 @@ public function delete_old_rows() {
 		$db = $this->get_db();
 
 		// Bail if no database interface is available.
-		if ( empty( $db ) ) {
+		if ( ! $db ) {
 			return false;
 		}
 
@@ -89,7 +89,7 @@ public function get_old_rows(): array {
 		$db = $this->get_db();
 
 		// Bail if no database interface is available.
-		if ( empty( $db ) ) {
+		if ( ! $db ) {
 			return false;
 		}
 
@@ -113,7 +113,7 @@ public function remove_all_completed_rows() {
 		$db = $this->get_db();
 
 		// Bail if no database interface is available.
-		if ( empty( $db ) ) {
+		if ( ! $db ) {
 			return false;
 		}
 

inc/Engine/CriticalPath/APIClient.php

@@ -108,7 +108,11 @@ private function get_response_success( $response_code, $response_data ) {
 		return (
 			200 === $response_code
 			&&
-			! empty( $response_data )
+			(
+				$response_data instanceof stdClass
+				&&
+				! empty( (array) $response_data )
+			)
 			&&
 			(
 				(

inc/Engine/License/views/promo-banner.php

@@ -6,6 +6,8 @@
  */
 
 defined( 'ABSPATH' ) || exit;
+
+$data = isset( $data ) ? $data : []; // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
 ?>
 <div class="rocket-promo-banner" id="rocket-promo-banner">
 	<div>

inc/Engine/License/views/renewal-expired-banner-ocd-disabled.php

@@ -6,6 +6,8 @@
  */
 
 defined( 'ABSPATH' ) || exit;
+
+$data = isset( $data ) ? $data : []; // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
 ?>
 <section class="rocket-renewal-expired-banner" id="rocket-renewal-banner">
 	<h3 class="rocket-expired-title"><?php esc_html_e( 'The Optimize CSS Delivery feature is disabled.', 'rocket' ); ?></h3>

inc/Engine/License/views/renewal-expired-banner-ocd.php

@@ -6,6 +6,8 @@
  */
 
 defined( 'ABSPATH' ) || exit;
+
+$data = isset( $data ) ? $data : []; // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
 ?>
 <section class="rocket-renewal-expired-banner" id="rocket-renewal-banner">
 	<h3 class="rocket-expired-title"><?php esc_html_e( 'You will soon lose access to some features.', 'rocket' ); ?></h3>

inc/Engine/License/views/renewal-expired-banner.php

@@ -6,6 +6,8 @@
  */
 
 defined( 'ABSPATH' ) || exit;
+
+$data = isset( $data ) ? $data : []; // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
 ?>
 <section class="rocket-renewal-expired-banner" id="rocket-renewal-banner">
 	<h3 class="rocket-expired-title"><?php esc_html_e( 'Your WP Rocket license is expired!', 'rocket' ); ?></h3>

inc/Engine/License/views/renewal-soon-banner.php

@@ -6,6 +6,8 @@
  */
 
 defined( 'ABSPATH' ) || exit;
+
+$data = isset( $data ) ? $data : []; // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
 ?>
 <div class="rocket-renewal-banner">
 	<ul class="rocket-promo-countdown" id="rocket-renew-countdown">

inc/Engine/License/views/upgrade-popin.php

@@ -6,6 +6,8 @@
  */
 
 defined( 'ABSPATH' ) || exit;
+
+$data = isset( $data ) ? $data : []; // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
 ?>
 <div class="wpr-Popin wpr-Popin-Upgrade">
 	<div class="wpr-Popin-header">

inc/Engine/Media/AboveTheFold/Database/Queries/AboveTheFold.php

@@ -85,7 +85,7 @@ public function make_job_completed( string $url, bool $is_mobile, array $data )
 		$db = $this->get_db();
 
 		// Bail if no database interface is available.
-		if ( empty( $db ) ) {
+		if ( ! $db ) {
 			return false;
 		}
 
@@ -115,7 +115,7 @@ public function delete_old_rows() {
 		$db = $this->get_db();
 
 		// Bail if no database interface is available.
-		if ( empty( $db ) ) {
+		if ( ! $db ) {
 			return false;
 		}
 

inc/Engine/Media/AboveTheFold/Frontend/Controller.php

@@ -147,7 +147,7 @@ private function set_fetchpriority( $lcp, string $html ): string {
 			'picture',
 		];
 
-		if ( empty( $lcp ) || empty( $lcp->type ) || ! in_array( $lcp->type, $allowed_types, true ) ) {
+		if ( empty( (array) $lcp ) || empty( $lcp->type ) || ! in_array( $lcp->type, $allowed_types, true ) ) {
 			return $html;
 		}
 
@@ -488,7 +488,7 @@ private function generate_source_tags( $lcp, $start_tag, $end_tag ) {
 			$link_attribute = ( substr_count( $source->srcset, ',' ) > 0 ) ? 'imagesrcset' : 'href';
 
 			// Append the source and media query to the tag string.
-			$tag .= $start_tag . $link_attribute . '="' . $source->srcset . '"' . ( $media ?? '' ) . $sizes . $end_tag;
+			$tag .= $start_tag . $link_attribute . '="' . $source->srcset . '"' . ( $media ) . $sizes . $end_tag;
 
 			// If a max-width is found in the source's media attribute, update the previous max-width.
 			if ( preg_match( '/\(max-width: (\d+(\.\d+)?)px\)/', $source->media, $matches ) ) {

inc/Engine/Media/ImageDimensions/ImageDimensions.php

@@ -208,10 +208,6 @@ private function is_external_file( $url ) {
 
 		$hosts = array_unique( $hosts );
 
-		if ( empty( $hosts ) ) {
-			return true;
-		}
-
 		// URL has domain and domain is part of the internal domains.
 		if ( ! empty( $file['host'] ) ) {
 			foreach ( $hosts as $host ) {

inc/Engine/Optimization/CSSTrait.php

@@ -469,10 +469,6 @@ protected function is_external_path( $url ) {
 
 		$hosts = array_unique( $hosts );
 
-		if ( empty( $hosts ) ) {
-			return true;
-		}
-
 		// URL has domain and domain is part of the internal domains.
 		if ( ! empty( $file['host'] ) ) {
 			foreach ( $hosts as $host ) {

inc/Engine/Optimization/RUCSS/Controller/UsedCSS.php

@@ -499,6 +499,8 @@ private function add_used_fonts_preload( string $html, string $used_css ): strin
 
 			// Making sure the excluded fonts array isn't empty to avoid excluding all fonts.
 			if ( ! empty( $exclude_fonts_preload ) ) {
+				$exclude_fonts_preload = array_filter( $exclude_fonts_preload );
+
 				// Combine the array elements into a single string with | as a separator and returning a pattern.
 				$exclude_fonts_preload_pattern = implode(
 					'|',

inc/Engine/Optimization/RUCSS/Database/Queries/UsedCSS.php

@@ -87,7 +87,7 @@ public function make_status_completed( string $url, bool $is_mobile, string $has
 		$db = $this->get_db();
 
 		// Bail if no database interface is available.
-		if ( empty( $db ) ) {
+		if ( ! $db ) {
 			return false;
 		}
 

inc/Engine/Optimization/UrlTrait.php

@@ -51,10 +51,6 @@ private function is_external_file( $url ) {
 
 		$hosts = array_unique( $hosts );
 
-		if ( empty( $hosts ) ) {
-			return true;
-		}
-
 		// URL has domain and domain is part of the internal domains.
 		if ( ! empty( $file['host'] ) ) {
 			foreach ( $hosts as $host ) {

inc/Engine/Preload/Controller/PreloadUrl.php

@@ -61,6 +61,9 @@ public function __construct( Options_Data $options, Queue $queue, Cache $rocket_
 	 * @return void
 	 */
 	public function preload_url( string $url ) {
+		$start    = 0;
+		$duration = 0;
+
 		$is_mobile = $this->options->get( 'do_caching_mobile_files', false );
 
 		if ( $this->is_already_cached( $url ) && ( ! $is_mobile || $this->is_already_cached( $url, true ) ) ) {

inc/Engine/Preload/Database/Queries/Cache.php

@@ -303,7 +303,7 @@ public function get_old_cache( float $delay = 1, string $unit = 'month' ): array
 		$db = $this->get_db();
 
 		// Bail if no database interface is available.
-		if ( empty( $db ) ) {
+		if ( ! $db ) {
 			return [];
 		}
 
@@ -473,7 +473,7 @@ public function revert_old_in_progress() {
 		$db = $this->get_db();
 
 		// Bail if no database interface is available.
-		if ( empty( $db ) ) {
+		if ( ! $db ) {
 			return false;
 		}
 
@@ -489,7 +489,7 @@ public function revert_old_failed() {
 		$db = $this->get_db();
 
 		// Bail if no database interface is available.
-		if ( empty( $db ) ) {
+		if ( ! $db ) {
 			return false;
 		}
 
@@ -505,7 +505,7 @@ public function set_all_to_pending() {
 		$db = $this->get_db();
 
 		// Bail if no database interface is available.
-		if ( empty( $db ) ) {
+		if ( ! $db ) {
 			return false;
 		}
 
@@ -568,7 +568,7 @@ public function remove_all() {
 		$db = $this->get_db();
 
 		// Bail if no database interface is available.
-		if ( empty( $db ) ) {
+		if ( ! $db ) {
 			return false;
 		}
 
@@ -603,7 +603,7 @@ public function unlock_all() {
 		$db = $this->get_db();
 
 		// Bail if no database interface is available.
-		if ( empty( $db ) ) {
+		if ( ! $db ) {
 			return false;
 		}
 

inc/ThirdParty/Plugins/Optimization/AMP.php

@@ -126,7 +126,7 @@ public function disable_options_on_amp() {
 
 		global $wp_filter;
 
-		remove_filter( 'wp_resource_hints', 'rocket_dns_prefetch', 10, 2 );
+		remove_filter( 'wp_resource_hints', 'rocket_dns_prefetch', 10 );
 		add_filter( 'do_rocket_lazyload', '__return_false' );
 		add_filter( 'do_rocket_lazyload_iframes', '__return_false' );
 		add_filter( 'pre_get_rocket_option_async_css', '__return_false' );

phpstan-bootstrap.php

@@ -0,0 +1,10 @@
+<?php
+	define( 'WP_ROCKET_PLUGIN_NAME', 'WP Rocket' );
+	define( 'WP_ROCKET_PLUGIN_SLUG', 'wp-rocket' );
+
+	define( 'AUTH_COOKIE', 'default_auth_cookie' );
+	define( 'LOGGED_IN_COOKIE', 'default_logged_in_cookie' );
+	define( 'PASS_COOKIE', 'default_pass_cookie' );
+	define( 'SECURE_AUTH_COOKIE', 'default_secure_auth_cookie' );
+	define( 'USER_COOKIE', 'default_user_cookie' );
+	define( 'WP_STACK_CDN_DOMAIN', '' );

phpstan.neon.dist

@@ -1,7 +1,7 @@
 includes:
 	- phar://phpstan.phar/conf/bleedingEdge.neon
 parameters:
-	level: 0
+	level: 1
 	inferPrivatePropertyTypeFromConstructor: true
 	paths:
 		# Test only the new architecture for now.
@@ -13,6 +13,8 @@ parameters:
 	bootstrapFiles:
 		# Must be first
 		- %currentWorkingDirectory%/inc/functions/options.php
+		# PHPStan bootstrap
+		- %currentWorkingDirectory%/phpstan-bootstrap.php
 		# Procedural code
 		- %currentWorkingDirectory%/inc/constants.php
 		- %currentWorkingDirectory%/inc/common/purge.php
@@ -41,6 +43,7 @@ parameters:
 		- %currentWorkingDirectory%/inc/admin/options.php
 		- %currentWorkingDirectory%/vendor/php-stubs/wordpress-stubs/wordpress-stubs.php
 		- %currentWorkingDirectory%/vendor/php-stubs/wordpress-tests-stubs/wordpress-tests-stubs.php
+		- %currentWorkingDirectory%/wp-rocket.php
 	excludePaths:
 		 - %currentWorkingDirectory%/inc/vendors/
 		 # These need plugin stubs!

tests/Fixtures/inc/ThirdParty/Hostings/LiteSpeed/override_header_functions.php

@@ -10,7 +10,7 @@ function headers_sent()
 	return false;
 }
 
-function header($string)
+function header($string, $replace)
 {
 	if (  in_array( $string , HeaderCollector::$headers, true ) ) {
 		return;

tests/Fixtures/inc/ThirdParty/Plugins/SEO/SEOPress/fixtures.php

@@ -1,6 +1,6 @@
 <?php
 if(! function_exists('seopress_get_toggle_option')) {
-	function seopress_get_toggle_option() {
+	function seopress_get_toggle_option( $name ) {
 		return '1';
 	}
 }

tests/Integration/inc/Engine/CriticalPath/CriticalCSSSubscriber/deleteCpcss.php

@@ -67,6 +67,8 @@ public function testShouldDoExpected( $config, $expected ) {
 		$this->filesystem->put_contents( $item_path, '.cpcss { color: red; }');
 		$this->assertTrue( $this->filesystem->exists( $item_path ) );
 
+		$mobile_item_path = '';
+
 		if ( $this->async_css_mobile ) {
 			$mobile_item_path = 'wp-content/cache/critical-css/1/posts' . DIRECTORY_SEPARATOR . "{$post_type}-" . self::$post_id . "-mobile.css";
 			$this->filesystem->put_contents( $mobile_item_path, '.cpcss-mobile { color: red; }');

tests/Integration/inc/Engine/CriticalPath/ProcessorService/processGenerate.php

@@ -138,7 +138,7 @@ public function testShouldDoExpected( $config, $expected ) {
 			}
 		}
 
-		if ( isset( $save_cpcss ) && is_wp_error( $save_cpcss ) ) {
+		if ( is_wp_error( $save_cpcss ) ) {
 			$this->filesystem->chmod( 'wp-content/cache/critical-css/1/', 0444 );
 		}
 

tests/Integration/inc/Engine/Media/ImageDimensions/Subscriber/specifyImageDimensions.php

@@ -28,7 +28,7 @@ public function tear_down() {
 			remove_filter( 'rocket_specify_image_dimensions', [$this, 'filter_rocket_specify_image_dimensions'] );
 		}
 
-		if ( isset( $config['rocket_specify_dimension_skip_pictures_filter'] ) ){
+		if ( isset( $this->config_data['rocket_specify_dimension_skip_pictures_filter'] ) ){
 			remove_filter( 'rocket_specify_dimension_skip_pictures', [$this, 'filter_rocket_specify_dimension_skip_pictures'] );
 		}