-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #6756 Increase phpstan level 2 #6761
Conversation
…nt/6756-increase-phpstan-level-2
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
…nt/6756-increase-phpstan-level-2
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Lee <[email protected]> Co-authored-by: Khadreal <[email protected]>
inc/classes/dependencies/mobiledetect/mobiledetectlib/Mobile_Detect.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran smoke & lcp tests on e2e for this branch, all passed.
Executed TP with following report:
testrail-report-619.pdf
One TC is failed but looks like failing on trunk too. Will be addressed separately.
Description
Fixes #6756
Documentation
User documentation
Technical documentation
Some tests were marked as skipped because they do not perform assertions in their current form. They need to be revisited.
Notable changes:
label
property is correctly set before using it when adding LCP data from AJAX requestsrc
property of the DB entry is empty when adding thefetchpriority
attribute to an imageType of change
Checklists
Feature validation
Code style