Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #6782

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Fix typos #6782

merged 3 commits into from
Jul 18, 2024

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Jul 13, 2024 •
edited
Loading

Description

Found few misspellings.

https://github.com/crate-ci/typos

💡 There is one remaining: rocket_exlude_wps_hide_login_page

Type of change

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as before).

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jul 13, 2024 •
edited
Loading

Please help me to fix tests.

@Tabrisrp Tabrisrp added the type: bug Indicates an unexpected problem or unintended behavior label Jul 18, 2024
@Tabrisrp
Copy link
Contributor

Thank you Viktor, seems to be all good.

Tests on external PRs are not running because of the usage of secrets, no worries with that since there is only typos fixes in comments/docblocks.

@Tabrisrp Tabrisrp added this pull request to the merge queue Jul 18, 2024
Merged via the queue into wp-media:develop with commit e3f0cb1 Jul 18, 2024
5 of 12 checks passed
@szepeviktor
Copy link
Contributor Author

Very glad to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tabrisrp Tabrisrp Tabrisrp approved these changes

Assignees

@szepeviktor szepeviktor

Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szepeviktor @Tabrisrp