Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6779: AboveTheFold Database Refactor #6794

Merged
merged 26 commits into from
Jul 30, 2024

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Jul 18, 2024

Description

Adds a Queries and Table interface to PerformanceHints + Respective AboveTheFold implementing them.
Fixes #6779

Documentation

User documentation

It shouldn't impact users

Technical documentation

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Documentation

  • I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
  • The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
  • I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.
  • I validated the repo-specific guidelines from CONTRIBUTING.md.

@Miraeld Miraeld added effort: [S] 1-2 days of estimated development time lcp labels Jul 18, 2024
@Miraeld Miraeld requested a review from a team July 18, 2024 02:08
@Miraeld Miraeld self-assigned this Jul 18, 2024
Copy link

codacy-production bot commented Jul 18, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 4dad0e21 47.50% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4dad0e2) Report Missing Report Missing Report Missing
Head commit (881b1b1) 37497 14611 38.97%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6794) 120 57 47.50%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@Miraeld Miraeld changed the base branch from develop to 3.17-atf-refactor July 18, 2024 08:18
@piotrbak piotrbak added module: OCI Optimize Critical Images and removed lcp labels Jul 18, 2024
Copy link
Contributor

@Tabrisrp Tabrisrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a conflict to fix

@jeawhanlee jeawhanlee changed the base branch from 3.17-atf-refactor to develop July 25, 2024 19:37
@jeawhanlee jeawhanlee changed the base branch from develop to 3.17-atf-refactor July 26, 2024 11:34
@jeawhanlee jeawhanlee changed the base branch from 3.17-atf-refactor to develop July 26, 2024 12:20
@jeawhanlee jeawhanlee changed the base branch from develop to 3.17-atf-refactor July 26, 2024 16:31
@jeawhanlee jeawhanlee requested a review from Tabrisrp July 26, 2024 16:32
@Miraeld Miraeld requested a review from jeawhanlee July 29, 2024 12:14
@jeawhanlee jeawhanlee changed the base branch from 3.17-atf-refactor to develop July 29, 2024 12:28
@jeawhanlee jeawhanlee changed the base branch from develop to 3.17-atf-refactor July 29, 2024 15:01
@Miraeld Miraeld merged commit 3eb3343 into 3.17-atf-refactor Jul 30, 2024
1 of 2 checks passed
@Miraeld Miraeld deleted the enhancement/6779-atf-db-refactor branch July 30, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: [S] 1-2 days of estimated development time module: OCI Optimize Critical Images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.17 Sub tasks - Database Refactoring
6 participants