Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes: #6772 Refactor activation process #6801

Conversation

Khadreal
Copy link
Contributor

Description

Move Activation from AboveTheFold namespace to Common/PerformanceHints

Fixes #6772

Documentation

User documentation

Explain how this code impacts users.

Technical documentation

Explain how this code works. Diagram & drawings are welcomed.

Type of change

Delete options that are not relevant.

  • Enhancement (non-breaking change which improves an existing functionality).

New dependencies

List any new dependencies that are required for this change.

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Documentation

  • I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
  • The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
  • I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

  • I did not introduce unecessary complexity.

Observability

  • I handled errors when needed.
  •  I wrote user-facing messages that are understandable and provide actionable feedbacks.
  • I prepared ways to observe the implemented system (logs, data, etc.).

Risks

  •  I explicitely mentioned performance risks in the PR.
  • I explicitely mentioned security risks in the PR.

@Khadreal Khadreal self-assigned this Jul 19, 2024
Copy link

codacy-production bot commented Jul 19, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for c64eea61 2.33% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c64eea6) Report Missing Report Missing Report Missing
Head commit (193ff75) 37429 14570 38.93%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6801) 43 1 2.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@Khadreal Khadreal changed the base branch from develop to 3.17-atf-refactor July 19, 2024 10:25
@Khadreal Khadreal marked this pull request as ready for review July 19, 2024 10:29
@Khadreal Khadreal added the type: enhancement Improvements that slightly enhance existing functionality and are fast to implement label Jul 19, 2024
@jeawhanlee jeawhanlee assigned jeawhanlee and unassigned jeawhanlee Jul 24, 2024
@jeawhanlee jeawhanlee changed the base branch from 3.17-atf-refactor to develop July 24, 2024 18:23
@jeawhanlee jeawhanlee changed the base branch from develop to 3.17-atf-refactor July 24, 2024 18:41
@jeawhanlee jeawhanlee changed the base branch from 3.17-atf-refactor to subtask/6774-3.17-refactor-warmup-process July 24, 2024 18:43
@jeawhanlee jeawhanlee requested a review from a team July 24, 2024 18:45
@jeawhanlee jeawhanlee self-assigned this Jul 25, 2024
@jeawhanlee jeawhanlee merged commit f0734fa into subtask/6774-3.17-refactor-warmup-process Jul 25, 2024
11 of 13 checks passed
@jeawhanlee jeawhanlee deleted the subtask/refactor-activation-process#6772 branch July 25, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.17 - Refactor Activation process
3 participants