Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6948 -- rocket_lrc_processed_tags should be case insensitive #6949

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

Khadreal
Copy link
Contributor

@Khadreal Khadreal commented Sep 5, 2024

Description

Make filter value case insensitive

Fixes #6948

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Check #6948 for scenario

Technical description

Convert filter values to upper case in get_processed_tags method.

Documentation

Make sure filter value are case insensitive.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I did not introduce unnecessary complexity.

@Khadreal Khadreal added the type: bug Indicates an unexpected problem or unintended behavior label Sep 5, 2024
@Khadreal Khadreal self-assigned this Sep 5, 2024
@Khadreal Khadreal linked an issue Sep 5, 2024 that may be closed by this pull request
@Khadreal Khadreal requested a review from a team September 5, 2024 09:19
Copy link

codacy-production bot commented Sep 5, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-43.63% (target: -0.10%) (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4d7b54b) 37912 16541 43.63%
Head commit (2eb92d2) 0 (-37912) 0 (-16541) 0.00% (-43.63%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6949) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@MathieuLamiot
Copy link
Contributor

@Khadreal what do you think of an integration test that registers a callback to the filter, adding lowercase items, and checking the output of the method to ensure they are uppercase?
I am confident your code works, but it could help capturing the behavior in case we refactor something later on?

@Khadreal
Copy link
Contributor Author

Khadreal commented Sep 5, 2024

If this PR is merged first then this would need to be updated.

@MathieuLamiot
Copy link
Contributor

I replicated the problematic scenario and it works as expected.

@MathieuLamiot MathieuLamiot merged commit 554dc2a into feature/lrc Sep 5, 2024
11 of 13 checks passed
@MathieuLamiot MathieuLamiot deleted the fix/6948-tag-case-insensitive branch September 5, 2024 18:38
@MathieuLamiot MathieuLamiot mentioned this pull request Sep 5, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rocket_lrc_processed_tags should be case insensitive
2 participants