Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6944 Add LRC hashes when using LRC query string #6955

Merged
merged 25 commits into from
Sep 11, 2024

Conversation

Tabrisrp
Copy link
Contributor

@Tabrisrp Tabrisrp commented Sep 5, 2024

Description

Fixes #6944

Add LRC hashes to the HTML when using the wpr_lazyrendercontent query string.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Details available in #6944

Technical description

Documentation

This PR contains additional internal changes, moving the existing buffer that was previously applied only for image dimensions to the performance hints namespace, updating the name, and splitting the code between the performance hints warmup subscriber, image dimensions subscriber and the LRC subscriber.

This decouples the buffer from the image dimensions namespace to a common one that current and future implementations can use.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

@Tabrisrp Tabrisrp added this to the 3.17 milestone Sep 5, 2024
@Tabrisrp Tabrisrp self-assigned this Sep 5, 2024
@Tabrisrp Tabrisrp changed the base branch from develop to feature/lrc September 5, 2024 20:21
@Tabrisrp Tabrisrp added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement module: ALR Issues related to the Automatic Lazy Rendering feature labels Sep 5, 2024
@Tabrisrp Tabrisrp requested a review from a team September 5, 2024 20:30
@Tabrisrp Tabrisrp marked this pull request as ready for review September 5, 2024 20:30
@Tabrisrp
Copy link
Contributor Author

Tabrisrp commented Sep 5, 2024

This can be reviewed, I'll add the tests for it tomorrow

Copy link

codacy-production bot commented Sep 6, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.11% (target: -0.10%) 48.28% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b2ae01f) 37937 16553 43.63%
Head commit (7c2274b) 37949 (+12) 16599 (+46) 43.74% (+0.11%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6955) 29 14 48.28%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@Tabrisrp
Copy link
Contributor Author

Tabrisrp commented Sep 9, 2024

We're good on coverage here, what remains not covered would not make sense to be tested, so this can go to QA

@Mai-Saad
Copy link
Contributor

Mai-Saad commented Sep 11, 2024

Working as expected knowing that we have

@MathieuLamiot MathieuLamiot merged commit be278fc into feature/lrc Sep 11, 2024
12 of 13 checks passed
@MathieuLamiot MathieuLamiot deleted the enhancement/6944-lrc-query-string branch September 11, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: ALR Issues related to the Automatic Lazy Rendering feature type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add query string to force LRC hash injection
5 participants