-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #6944 Add LRC hashes when using LRC query string #6955
Closes #6944 Add LRC hashes when using LRC query string #6955
Conversation
This can be reviewed, I'll add the tests for it tomorrow |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
…ia/wp-rocket into enhancement/6944-lrc-query-string
…ia/wp-rocket into enhancement/6944-lrc-query-string
…m/wp-media/wp-rocket into enhancement/6944-lrc-query-string
We're good on coverage here, what remains not covered would not make sense to be tested, so this can go to QA |
Working as expected knowing that we have
|
…ent/6944-lrc-query-string
Description
Fixes #6944
Add LRC hashes to the HTML when using the
wpr_lazyrendercontent
query string.Type of change
Detailed scenario
Details available in #6944
Technical description
Documentation
This PR contains additional internal changes, moving the existing buffer that was previously applied only for image dimensions to the performance hints namespace, updating the name, and splitting the code between the performance hints warmup subscriber, image dimensions subscriber and the LRC subscriber.
This decouples the buffer from the image dimensions namespace to a common one that current and future implementations can use.
Mandatory Checklist
Code validation
Code style