Decrease contention while GetDirectory is running by 153986x. #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I'm cutting my teeth on this before fixing the horrendousness that's been going on in NFS ( xbmc/xbmc#22834 ) this entire time. Presently for god knows what reason there's a litany of lock and unlock events while spinning through GetDirectory which obviously isn't great for anyone. While untested, from a pure observation point of view for one of my directories this reduces the amount of lock calls from 153986 to 6. I'd love to get some performance numbers in here for fun but no one has updated the build information in years so new developers can't actually test their addon changes (with core being a challenge, but possible with going off road a bit).
xbmc/xbmc#22835