Add missing default xbuffer_adaptor #2777
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… shared memory between xtensor_adaptor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the support for shared pointer by xtensor_adaptor/xbuffer_adaptor. The default constructor was declared but not implemented. A default implementation is sufficient. Also the move operators are brought
Checklist
Description
This small correction fix a link error when shared_ptr backing storage is used. It transforms an explicit constructor to a default constructor, otherwise the implementation is missing.
This pull request also adds unit tests for xbuffer_adaptor and xtensor_adaptor when a shared_ptr is used for backing storage. It tests the compilability and the semantic.