(Sonar) Fixed finding: "@Override should be used on overriding and implementing methods"

[pixeeai]

Remediation

This change fixes "@Override should be used on overriding and implementing methods" (id = java:S1161) identified by Sonar.

Details

This change adds missing @Override to known subclasses. Documenting inheritance will help readers and static analysis tools understand the code better, spot bugs easier, and in general lead to more efficient and effective review.

Our changes look something like this:

  interface AcmeParent {
     void doThing();
  } 

  class AcmeChild implements AcmeParent {

+   @Override
    void doThing() {
      thing();
    }
    
  }

More reading

• https://rules.sonarsource.com/java/RSPEC-1161/

🧚🤖 Powered by Pixeebot

Feedback | Community | Docs | Codemod ID: sonar:java/add-missing-override-s1161

[pixeeai]

This change was autogenerated from a GitHub app - called Pixeebot. A code-quality GitHub App; like Dependabot, but for source code. Feel free to check it our for more details for how you can install it onto your project's repo for continued code hardening and code security recommendations. 👍

[manuelleduc]

This PR is very limited, an accurate PR would fix all the missing override annotations at once.

[vmassol]

@manuelleduc sure but we should still apply it IMO as it looks good