-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to ape and add features #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks very solid! thank you.
things to think about:
- should we simplify funding to one transfer?
- should we use blueprint vs minimal proxy?
- should rug pullability be defined at creation? counterpoint: you can bundle multiple actions when deploying from a dao or safe.
- should we change admin change to a single step?
- it should be possible to recover the vested token sent to the contract minus still locked amount, add a test demonstrating that.
another decision:
|
writing the full spec in #17, it supersedes all the comments |
log SetFree(admin) | ||
log VestingTerminated(self.recipient, admin, ruggable, ts) | ||
log Disowned(owner) | ||
log Revoked(self.recipient, owner, ruggable, ts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also log beneficiary
also let's use time
instead of ts
805b41a
to
4a21429
Compare
- run black with line-length = 120
- zero address and non zero amount - zero address and zero amount
- update accounts - rename ychad to owner
- fix formatting
- return dev reverts - add foundry host
58d5659
to
afaadcb
Compare
cf7ffbf
to
97a55db
Compare
291a791
to
2763112
Compare
closes #15