Update mongo repsert and replace calls #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace mongo driver save and replace calls with updateMany to restore correct behavior in MongoDB >=6.0
parsonsmatt
reviewed
Sep 12, 2024
parsonsmatt
reviewed
Sep 12, 2024
Co-authored-by: Matt Parsons <[email protected]>
Yes, there should be no impact; the change is backwards compatible |
|
Thanks! Uploaded to Hackage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace mongo driver
saveandreplaceAPI calls withupdateManyto restore correct behavior in MongoDB >=6.0This is an extension of #1545. The change in behavior lies in the underlying driver
updatefunction which is called indirectly via persistent'srepsertandreplaceAPIs. In this function, the driver uses a write concern of 0 overriding the preference set by the mongo access mode or default write concern as configured in the DB. In test suites or other scenarios where the written data is immediately queried for again from a secondary this can result in flaky "Not Found" failures.I have opened a PR against the driver library to directly address this issue among others, however, until that change gets approved and merged we can circumvent the problem here in this repository which has more active maintenance.