Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update monad-logger upper bound #1793

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ocharles
Copy link
Contributor

0.3.38 (which I think should have been 0.4?) removed instances that yesod-core depended on. Without this, we get:

src/Yesod/Core/Class/Handler.hs:79:10: error:
    • Could not deduce (MonadLogger (ListT m))
        arising from the superclasses of an instance declaration
      from the context: MonadHandler m
        bound by the instance declaration
        at src/Yesod/Core/Class/Handler.hs:79:10-49
    • In the instance declaration for ‘MonadHandler (ListT m)’
   |
79 | GO(ListT)
   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

0.3.38 (which I think should have been 0.4?) removed instances that `yesod-core` depended on. Without this, we get:

```
src/Yesod/Core/Class/Handler.hs:79:10: error:
    • Could not deduce (MonadLogger (ListT m))
        arising from the superclasses of an instance declaration
      from the context: MonadHandler m
        bound by the instance declaration
        at src/Yesod/Core/Class/Handler.hs:79:10-49
    • In the instance declaration for ‘MonadHandler (ListT m)’
   |
79 | GO(ListT)
   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant