Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YouTube] Realign n-sig processing with yt-dlp #32695

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Conversation

dirkf
Copy link
Contributor

@dirkf dirkf commented Jan 16, 2024

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense except for code from yt-dlp where either this or the below has already been asserted.
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This PR revises the processing of the n-sig YT parameter in the YoutubeIE extractor to realign the code with that in yt-dlp.

Some additional methods from the yt-dlp InfoExtractor class have already been back-ported in yt-dlp; this PR adds further such methods needed by the unified code.

Finally, some obvious test failures are fixed, including a new extraction tactic for like_count from likeButtonViewModel in the YT page, as recently implemented in yt-dlp (thanks @Ganesh910, yt-dlp/yt-dlp#8763).

…st.Request` constructor

* fixes ytdl-org#32573
* does not break `utils.HEADrequest` (eg)
@dirkf dirkf force-pushed the master branch 2 times, most recently from 7ff19e9 to 6f58da0 Compare January 20, 2024 20:21
@dirkf dirkf merged commit dc512e3 into ytdl-org:master Jan 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant