Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Youtube] Fix AttributeError no attribute '_YoutubeIE__ie_msg' if unable to decode n-parameter #32752

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

gy-chen
Copy link
Contributor

@gy-chen gy-chen commented Mar 23, 2024

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch. This is a bleeding chunk of code moved to InfoExtractor, as you've plainly found. Your fix is what should have been committed.

@dirkf dirkf changed the title fix AttributeError no attribute '_YoutubeIE__ie_msg' if unable to decode n-parameter [Youtube] Fix AttributeError no attribute '_YoutubeIE__ie_msg' if unable to decode n-parameter Mar 23, 2024
@dirkf dirkf merged commit 71211e7 into ytdl-org:master Mar 23, 2024
14 checks passed
@dirkf
Copy link
Contributor

dirkf commented Mar 23, 2024

This (should-be) obvious bug isn't being detected by flake8 or even pylint, which does detect a less complicated case as E1101: Instance of '{class}' has no '__private_meth' member (no-member).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants