Drop create shim build #1776

GarrettS · 2014-04-10T16:57:21Z

I just added changes from /src. Did I get the pull request right this time?

yahoocla · 2014-04-10T16:57:22Z

CLA is valid!

caridy · 2014-04-10T18:48:48Z

Hey @GarrettS you're getting there. At least I can see your changes (3 files), but your commit is including things that are not needed in the PR, specifically, you committed the build folder, and it seems that you also did a wrong build within the src/build folder. You should probably update this PR or just issue a new one. The trick is: check the diff before submitting the PR, you should see only 3 files:

src/dd/js/drop.js
src/dd/tests/unit/assets/dd-tests.js
src/dd/tests/unit/index.html

which is what your change is all about, if you see something else, it is just adding noise for us to review it and merge it. does that makes sense?

Garrett Smith added 5 commits April 8, 2014 11:11

_createShim test and fix

19c060d

commit _createShim fix for build

504516f

remove duplicat var s;

027651c

touched

b5ae07d

drop create shim src

2b97029

okuryu force-pushed the dev-3.x branch from f7cd44c to 9d14e3f Compare August 28, 2014 12:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop create shim build #1776

Drop create shim build #1776

GarrettS commented Apr 10, 2014

yahoocla commented Apr 10, 2014

caridy commented Apr 10, 2014

Drop create shim build #1776

Are you sure you want to change the base?

Drop create shim build #1776

Conversation

GarrettS commented Apr 10, 2014

yahoocla commented Apr 10, 2014

caridy commented Apr 10, 2014