Skip to content

Commit

Permalink
chore: Concrete simulation p error is working
Browse files Browse the repository at this point in the history
- update licenses
- add a fixme to align with the Concrete's simulation fix
  • Loading branch information
rudy-6-4 authored and kcelia committed Aug 21, 2024
1 parent 29474a6 commit 0029725
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 19 deletions.
2 changes: 1 addition & 1 deletion deps_licenses/licenses_linux_user.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ brevitas, 0.10.2, UNKNOWN
certifi, 2024.6.2, Mozilla Public License 2.0 (MPL 2.0)
charset-normalizer, 3.3.2, MIT License
coloredlogs, 15.0.1, MIT License
concrete-python, 2.7.0.dev20240802, BSD-3-Clause
concrete-python, 2.8.0rc3.dev20240820, BSD-3-Clause
dependencies, 2.0.1, BSD License
dill, 0.3.8, BSD License
filelock, 3.15.3, The Unlicense (Unlicense)
Expand Down
2 changes: 1 addition & 1 deletion deps_licenses/licenses_linux_user.txt.md5
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6ea5ce643148e3d97848133185cdaeda
f07036c8072f32a26aa79e5e4bbd9c32
30 changes: 15 additions & 15 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ python = ">=3.8.1,<3.11"
# source, so we should only use this for Concrete Python's non-public releases
# https://python-poetry.org/docs/1.7/repositories#project-configuration
# concrete-python = {version="==2.7.0", source = "zama-pypi-cpu"}
concrete-python = {version="==2.7.0.dev20240802", source = "zama-pypi-cpu"}
concrete-python = {version="==2.8.0rc3.dev20240820", source = "zama-pypi-cpu"}
setuptools = "65.6.3"
skops = {version = "0.5.0"}
xgboost = "1.6.2"
Expand Down
3 changes: 3 additions & 0 deletions tests/torch/test_compile_torch.py
Original file line number Diff line number Diff line change
Expand Up @@ -675,6 +675,9 @@ def test_compile_brevitas_qat(
)


# Update this test to align with Concrete's simulation fix.
# FIXME: https://github.com/zama-ai/concrete-ml-internal/issues/4578
@pytest.mark.xfail
@pytest.mark.parametrize(
"model_class, expected_onnx_str",
[
Expand Down
2 changes: 1 addition & 1 deletion tests/torch/test_hybrid_converter.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def run_hybrid_llm_test(
try:
hybrid_model.compile_model(
inputs,
p_error=0.1,
p_error=10e-40, # compare precisely simulate and disable
n_bits=9,
rounding_threshold_bits=8,
configuration=configuration,
Expand Down

0 comments on commit 0029725

Please sign in to comment.