Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial equality checking #31

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Partial equality checking #31

wants to merge 7 commits into from

Conversation

TomNicholas
Copy link
Collaborator

WIP towards actually doing full element-wise equality checking between ManifestArray objects.

@TomNicholas TomNicholas mentioned this pull request Mar 14, 2024
@TomNicholas TomNicholas changed the base branch from main to equality March 14, 2024 16:54
@TomNicholas TomNicholas changed the base branch from equality to main March 14, 2024 16:54
@dcherian
Copy link

Can this be avoided with sensible default options for concat? data_vars="minimal", coords="minimal", compat="override"?

@TomNicholas
Copy link
Collaborator Author

TomNicholas commented Jun 27, 2024

Can this be avoided with sensible default options for concat? data_vars="minimal", coords="minimal", compat="override"?

This __eq__ method isn't actually used during concat I don't think. I just implemented it so that I could call xrt.assert_equal on virtual datasets. This PR would make the result more useful in cases where some but not all of the chunks in two manifests are equivalent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants