net: Avoid building native stack components with CONFIG_NET_NATIVE=n #79206
+3,379
−3,236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlubos
force-pushed
the
net/sockets-syscalls-split
branch
from
2e3b2b3
to
294532e
Compare
|
@jukkar What's your say on It's about |
|
Added a commit removing the faulty macro, just in case. |
jukkar
previously approved these changes
Sep 30, 2024
Overriding is a good choice, I think the macro just hides things without being useful. |
rlubos
force-pushed
the
net/sockets-syscalls-split
branch
from
11f69a2
to
dfa3631
Compare
Native IP socket implementation need only be build if native IP stack is enabled. Therefore, split the native IP sockets from the common socket syscalls shared across all socket implementations. Signed-off-by: Robert Lubos <[email protected]>
In case NET_NATIVE is disabled, certain network stack components do not need to be compiled. Otherwise, they could throw errors if --no-gc-sections compiler options is enabled. Signed-off-by: Robert Lubos <[email protected]>
Net offloading doesn't need net TC threads to be enabled as they're used by the native stack. This fixes build if CONFIG_NET_OFFLOAD is enabled but native stack is disabled. Signed-off-by: Robert Lubos <[email protected]>
Macros with flow control are discouraged and generate compliance error, hence remove it and replace the corresponding code with simple errno assignments. Signed-off-by: Robert Lubos <[email protected]>
rlubos
force-pushed
the
net/sockets-syscalls-split
branch
from
dfa3631
to
6e833a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another set of changes for better separation of native network stack and offloaded cases. This disables building of native stack features when NET_NATIVE is disabled. It's been reported that builds may fail with
--no-gc-sectionsoption enabled.The major change here is separation of generic socket code (syscalls shared between native and offloaded implementations) from native IP sockets implementation. For some reason git produced pretty scary diff, but in reality the
sockets.cfile has simply been split into two.