Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qual: Enable phan on modulebuilder #30652

Merged
merged 13 commits into from
Aug 18, 2024

Conversation

mdeweerd
Copy link
Contributor

Qual: Enable phan on modulebuilder

Most files of the modulebuilder template can be checked as regular files.
It will help improve the template

@mdeweerd mdeweerd force-pushed the phan_stan/modulebuilder branch 9 times, most recently from b5ff9be to 71c3c4d Compare August 16, 2024 23:58
@mdeweerd
Copy link
Contributor Author

There is one remaining issue that I leave up to the merger ;-).

// Lookup the table dicname
$checkTable = $newdicname !== null && $db->DDLDescTable(MAIN_DB_PREFIX.strtolower($newdicname));
if ($checkTable && $db->num_rows($checkTable) <= 0) {
$error++;
}

@mdeweerd mdeweerd marked this pull request as ready for review August 17, 2024 00:04
@mdeweerd mdeweerd force-pushed the phan_stan/modulebuilder branch 8 times, most recently from 4136ffd to 6bcc688 Compare August 17, 2024 22:46
@mdeweerd mdeweerd force-pushed the phan_stan/modulebuilder branch 2 times, most recently from 4384786 to 417aaa1 Compare August 17, 2024 23:30
@mdeweerd
Copy link
Contributor Author

@eldy
With the changes to the develop branch this is kind of a moving target, but now it's back downto just the case mentioned above that you probably instantly know the fix for #30652 (comment) .

@eldy eldy merged commit b0087aa into Dolibarr:develop Aug 18, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants