Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qual: Enable phan on modulebuilder #30652

Merged
merged 13 commits into from
Aug 18, 2024
Merged

Qual: Enable phan on modulebuilder #30652

merged 13 commits into from
Aug 18, 2024

Commits on Aug 17, 2024

  1. Allow null for buyer, and force '' for in printObjectLine(s)

    @mdeweerd
    mdeweerd committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    5884b47 View commit details
    Browse the repository at this point in the history

  2. Allow null for Contact in show_actions_done

    @mdeweerd
    mdeweerd committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    24b2224 View commit details
    Browse the repository at this point in the history

  3. Qual: Enable phan on modulebuilder 

    # Qual: Enable phan on modulebuilder

Most files of the modulebuilder template can be checked as regular files.
It will help improve the template
    @mdeweerd
    mdeweerd committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    2d3be1a View commit details
    Browse the repository at this point in the history

  4. Update baseline (enable modulebuilder notices)

    @mdeweerd
    mdeweerd committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    9d2517d View commit details
    Browse the repository at this point in the history

  5. Add properties that are expected to exist on modules_boxes

    @mdeweerd
    mdeweerd committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    c019306 View commit details
    Browse the repository at this point in the history

  6. Qual: Ignore false positive (phan)

    @mdeweerd
    mdeweerd committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    dcb411b View commit details
    Browse the repository at this point in the history

  7. Set phpdoc type to include null on formAddObjectLine

    @mdeweerd
    mdeweerd committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    fdbe1bb View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. Qual: Fixes for modulebuilder (phan, phpstan, bugs, format)

    @mdeweerd
    mdeweerd committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    d559289 View commit details
    Browse the repository at this point in the history

  2. Fix phpcs for intracom

    @mdeweerd
    mdeweerd committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    62b1bd6 View commit details
    Browse the repository at this point in the history

  3. Make ModeleBoxes:showBox() signature match child class's

    @mdeweerd
    mdeweerd committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    0755e6f View commit details
    Browse the repository at this point in the history

  4. Fix *box::showBox() phpdoc types

    @mdeweerd
    mdeweerd committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    fe9053d View commit details
    Browse the repository at this point in the history

  5. Update index.php

    @eldy
    eldy authored Aug 18, 2024
    Configuration menu
    Copy the full SHA
    1db8210 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into phan_stan/modulebuilder

    @eldy
    eldy authored Aug 18, 2024
    Configuration menu
    Copy the full SHA
    836bdf5 View commit details
    Browse the repository at this point in the history