[DRAFT][compiler] Support RmsNorm Op and Fuse #13967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seockho-kim
added
the
DRAFT
seockho-kim
changed the title
seockho-kim
changed the title
|
For #13964 |
seanshpark
reviewed
Sep 10, 2024
|
Great work! Overall codes looks OK. Reviewers will take a deeper reading with each PRs. Let's begin posting PRs :)
would be nice. |
glistening
reviewed
Sep 10, 2024
| @@ -623,6 +624,7 @@ union BuiltinOptions { | |||
| BCQGatherOptions = 252, | |||
| BCQFullyConnectedOptions = 253, | |||
| InstanceNormOptions = 254, | |||
| RmsNormOptions = 255, | |||
There was a problem hiding this comment.
Please use 250, instead of 255.
There was a problem hiding this comment.
Okay, I'll update it.
ref) RightShiftOptions = 126, so we have 100+ rooms.
jinevening
reviewed
Sep 10, 2024
compiler/one-cmds/onelib/constant.py
Outdated
| @@ -48,6 +48,7 @@ class CONSTANT: | |||
| 'fuse_instnorm', | |||
| 'fuse_prelu', | |||
| 'fuse_gelu', | |||
| 'fuse_rmsnorm', | |||
There was a problem hiding this comment.
Could you exclude this option in O1? Our backend compiler is not ready for this change.
There was a problem hiding this comment.
Oh, I couldn't think of that.
I'll update it :)
- Reverted 0.8 - Added RmsNorm to 0.9 - BuiltinOption number changed in nnpackage circle schema.
This was referenced Sep 13, 2024
This was referenced Sep 24, 2024
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support LLM,
ONE-DCO-1.0-Signed-off-by: seockho.kim [email protected]