Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate Makefiles with mistakes #1440

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Regenerate Makefiles with mistakes #1440

merged 1 commit into from
Aug 30, 2024
+70 −40

Conversation

IuliaCMoldovan
Copy link
Contributor

PR Description

Regenerated the Makefiles and I noticed these have notable differences and should be updated.
I did not build any affected library/project as I'm waiting on the PR run to give the status.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

PIoandan
PIoandan previously approved these changes Aug 30, 2024
View reviewed changes
PopPaul2021
PopPaul2021 previously approved these changes Aug 30, 2024
View reviewed changes
@IuliaCMoldovan IuliaCMoldovan merged commit 19c48fc into main Aug 30, 2024
1 of 2 checks passed
@IuliaCMoldovan IuliaCMoldovan deleted the fix_makefiles branch August 30, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastmaier gastmaier gastmaier approved these changes

@PopPaul2021 PopPaul2021 PopPaul2021 left review comments

@PIoandan PIoandan PIoandan left review comments

@AndreiGrozav AndreiGrozav Awaiting requested review from AndreiGrozav AndreiGrozav is a code owner

@acostina acostina Awaiting requested review from acostina acostina is a code owner

@AndrDragomir AndrDragomir Awaiting requested review from AndrDragomir AndrDragomir is a code owner

@bluncan bluncan Awaiting requested review from bluncan bluncan is a code owner

@FilipG24 FilipG24 Awaiting requested review from FilipG24 FilipG24 is a code owner

@LBFFilho LBFFilho Awaiting requested review from LBFFilho LBFFilho is a code owner

@StancaPop StancaPop Awaiting requested review from StancaPop StancaPop is a code owner

@sarpadi sarpadi Awaiting requested review from sarpadi sarpadi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IuliaCMoldovan @gastmaier @PopPaul2021 @PIoandan