[ENH] Ranking for Sieve, refactoring of Sieve, Mosaic and VizRank #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.64%@@ master #1382 diff @@
==========================================
Files 75 75
Lines 7468 7473 +5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 6545 6550 +5
Misses 923 923
Partials 0 0
|
janezd
changed the title
janezd
force-pushed
the
sieve-rank
branch
2 times, most recently
from
11aa038
to
512c35b
Compare
janezd
force-pushed
the
sieve-rank
branch
2 times, most recently
from
ba49dda
to
0e90d8a
Compare
Extract OWWidget's methods for progress bars to mix-in class `Orange.widgets.utils.progressbar.ProgressBarMixin`. This simplifies `OWWidget` and also allows other dialogs (e.g. `VizRankDialog`) to use progress bars without being derived from `OWWidget`. Move `HorizontalGridDelegate` from `OWColor` to `gui` - it was also used in the `OWFile` 's domain editor and now in VizRank. Move `CanvasText`, `CanvasRectangle` and `ViewWithPress` from `OWMosaic` to `orange.widgets.visualize.utils` since they were used by Sieve and Mosaic (and may also be used elsewhere). Move the common functionality of Scatter Plot's and Sieve's VizRank to more `VizRankDialog` and `VizRankDialogAttrPair` (module `orange.widgets.visualiza.utils`. The classes are also general enough to also support ranking of other visualizations in the future. Derive `VizRankDialog` from `QDialog` (with the progress bar mix-in) instead of `OWWidget` with all its balast. Visually improve VizRankDialog. Remove the uninformative score. Remove the redundant dictionary `ScaleData.attribute_name_index` since it duplicates the functionality of `ScaleData.data_domain.index`. Fix the type of argument `buttonType` and the return type in docstring of `gui.button`. Rename `Orange.widget.utils.getHtmlCompatibleString` to `to_html`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guiCommit 512c35b is a massive clean-up which puts some classes shared across multiple widgets into different utility modules, and puts the general viz rank code into a common base class.