Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Ranking for Sieve, refactoring of Sieve, Mosaic and VizRank #1382

Merged
merged 9 commits into from
Jul 1, 2016
Merged

[ENH] Ranking for Sieve, refactoring of Sieve, Mosaic and VizRank #1382

merged 9 commits into from
Jul 1, 2016

Commits on Jul 1, 2016

  1. Sieve: Refactor drawing

    @janezd
    janezd committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    98fe508 View commit details
    Browse the repository at this point in the history

  2. Sieve: Add VizRank

    @janezd
    janezd committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    94e77ad View commit details
    Browse the repository at this point in the history

  3. gui.py: Allow specifying size policy as tuple

    @janezd
    janezd committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    5359f3a View commit details
    Browse the repository at this point in the history

  4. Sieve: Refactoring and fixes

    @janezd
    janezd committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    584a6ee View commit details
    Browse the repository at this point in the history

  5. preprocess.Discretize: Add flags for discretization of classes and metas

    @janezd
    janezd committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    c1a379f View commit details
    Browse the repository at this point in the history

  6. Sieve: Fix discretization of classes and metas

    @janezd
    janezd committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    424b946 View commit details
    Browse the repository at this point in the history

  7. Sieve: Improve VizRank layout

    @janezd
    janezd committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    e60b140 View commit details
    Browse the repository at this point in the history

  8. Refactoring of Sieve, Mosaic and VizRank. 

    Extract OWWidget's methods for progress bars to mix-in class `Orange.widgets.utils.progressbar.ProgressBarMixin`. This simplifies `OWWidget` and also allows other dialogs (e.g. `VizRankDialog`) to use progress bars without being derived from `OWWidget`.

Move `HorizontalGridDelegate` from `OWColor` to `gui` - it was also used in the `OWFile` 's domain editor and now in VizRank.

Move `CanvasText`, `CanvasRectangle` and `ViewWithPress` from `OWMosaic` to `orange.widgets.visualize.utils` since they were used by Sieve and Mosaic (and may also be used elsewhere).

Move the common functionality of Scatter Plot's and Sieve's VizRank to more `VizRankDialog` and `VizRankDialogAttrPair` (module `orange.widgets.visualiza.utils`. The classes are also general enough to also support ranking of other visualizations in the future.

Derive `VizRankDialog` from `QDialog` (with the progress bar mix-in) instead of `OWWidget` with all its balast.

Visually improve VizRankDialog. Remove the uninformative score.

Remove the redundant dictionary `ScaleData.attribute_name_index` since it duplicates the functionality of `ScaleData.data_domain.index`.

Fix the type of argument `buttonType` and the return type in docstring of `gui.button`.

Rename `Orange.widget.utils.getHtmlCompatibleString` to `to_html`.
    @janezd
    janezd committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    20a860c View commit details
    Browse the repository at this point in the history

  9. VizRank: fix iterate_states, other small fixes

    @janezd
    janezd committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    d29cf14 View commit details
    Browse the repository at this point in the history