[ENH] Variable lists (with QListView) optimizations #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... where used to select variable length (large) models.
Codecov Report
@@ Coverage Diff @@
## master #2994 +/- ##
==========================================
+ Coverage 81.88% 81.88% +<.01%
==========================================
Files 329 329
Lines 56867 56871 +4
==========================================
+ Hits 46564 46568 +4
Misses 10303 10303 |
The default implementations in QAbstractListItemModel is sufficient
and faster ('index' in particular is on a hot path in the Qt
model/view framework so it needs to be fast)
... when the displayed model is empty.
ales-erjavec
force-pushed
the
model-views-optimizations
branch
from
d1c26fd
to
1a75370
Compare
i.e. when used to display dynamic content
markotoplak
changed the title
markotoplak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Variable selection/display or large (wide) tables is slow.
Related to gh-2972
Description of changes
Includes