Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Variable lists (with QListView) optimizations #2994

Merged
merged 7 commits into from
Apr 13, 2018
Merged

[ENH] Variable lists (with QListView) optimizations #2994

merged 7 commits into from
Apr 13, 2018

Commits on Apr 10, 2018

  1. gui: ComboBox popup layout optimization

    @ales-erjavec
    ales-erjavec committed Apr 10, 2018
    Configuration menu
    Copy the full SHA
    9c8da31 View commit details
    Browse the repository at this point in the history

  2. widget: Replace use of QComboBox with gui.OrangeComboBox 

    ... where used to select variable length (large) models.
    @ales-erjavec
    ales-erjavec committed Apr 10, 2018
    Configuration menu
    Copy the full SHA
    07640ed View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2018

  1. widget: Use QListView.uniformItemSizes where applicable

    @ales-erjavec
    ales-erjavec committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    0aa1779 View commit details
    Browse the repository at this point in the history

  2. PyListModel: Remove 'index' reimplementation. 

    The default implementations in QAbstractListItemModel is sufficient
and faster ('index' in particular is on a hot path in the Qt
model/view framework so it needs to be fast)
    @ales-erjavec
    ales-erjavec committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    2f09655 View commit details
    Browse the repository at this point in the history

  3. PyListModel: Inline len(self) in rowCount implementation

    @ales-erjavec
    ales-erjavec committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    5752d0d View commit details
    Browse the repository at this point in the history

  4. gui: Fix an type error in CallFrontListView 

    ... when the displayed model is empty.
    @ales-erjavec
    ales-erjavec committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    1a75370 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2018

  1. widgets: Add contentsLength to gui.comboBox calls where applicable 

    i.e. when used to display dynamic content
    @ales-erjavec
    ales-erjavec committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    24e6ce0 View commit details
    Browse the repository at this point in the history