[FIX] OWWidget: Remove wheelEvent reimplementation #3557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This probably does no work. It is probably an attempt to interrupt the windows behavior where the wheel events are delivered to the widget with the keyboard focus even when the cursor is not over them. It can however interfere with phased/inertial scrolling.
Codecov Report
@@ Coverage Diff @@
## master #3557 +/- ##
=========================================
+ Coverage 83.79% 83.8% +<.01%
=========================================
Files 370 370
Lines 66823 66821 -2
=========================================
+ Hits 55997 55999 +2
+ Misses 10826 10822 -4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes gh-3152
Description of changes
Remove wheelEvent reimplementation.
It was probably an attempt to interrupt the windows behavior where the wheel events are delivered to the widget with the keyboard focus even when the cursor is not over them.
It can however interfere with phased/inertial scrolling.
Includes