[FIX] owtestandscore: Add cancelled tasks to dispose queue #4615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4615 +/- ##
==========================================
- Coverage 83.63% 83.62% -0.01%
==========================================
Files 281 276 -5
Lines 56226 55446 -780
==========================================
- Hits 47022 46366 -656
+ Misses 9204 9080 -124 |
ales-erjavec
changed the title
ales-erjavec
force-pushed
the
fixes/test-learners-segfault
branch
from
2e23f77
to
50c4b3d
Compare
ales-erjavec
changed the title
|
Seem to work - I can not crash it anymore. Does this mean we need to add something like this to other widgets that use threads? |
|
I don't know. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Annother stab at gh-4553
Description of changes
Includes