Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an API test failure on macOS #13732

Merged
merged 1 commit into from
May 31, 2024
Merged

Commits on May 26, 2024

  1. Fix an API test failure on macOS

    Before this fix, Monaco API KeybindingService.resolveKeybinding test was failing
    on macOS with
    
    ```
    AssertionError: expected { label: '⌃⇧⌥⌘K', …(6) } to deeply equal { label: '⌃⇧⌥⌘K', …(7) }
    + expected - actual
    
    {
     "WYSIWYG": true
     "ariaLabel": "⌃⇧⌥⌘K"
    +  "chord": false
     "dispatchParts": [
       "ctrl+shift+alt+meta+K"
     ]
     "electronAccelerator": "Ctrl+Shift+Alt+Cmd+K"
    ```
    
    The `chord: false` was removed from the expected object for other platforms
    as part of eclipse-theia#13217.
    
    This fix removes it from the expected object for macOS.
    pisv committed May 26, 2024
    Configuration menu
    Copy the full SHA
    b7ae53a View commit details
    Browse the repository at this point in the history