Fix an API test failure on macOS #13732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, Monaco API KeybindingService.resolveKeybinding test was failing
on macOS with
```
AssertionError: expected { label: '⌃⇧⌥⌘K', …(6) } to deeply equal { label: '⌃⇧⌥⌘K', …(7) }
+ expected - actual
{
"WYSIWYG": true
"ariaLabel": "⌃⇧⌥⌘K"
+ "chord": false
"dispatchParts": [
"ctrl+shift+alt+meta+K"
]
"electronAccelerator": "Ctrl+Shift+Alt+Cmd+K"
```
The `chord: false` was removed from the expected object for other platforms
as part of eclipse-theia#13217.
This fix removes it from the expected object for macOS.
|
@JonasHelming Someone on your side available to review this? Neither Jonah nor I have a Mac. |
|
@msujew We don't have Macs here either. |
|
I have one at home, but I'm not there right now ;-) |
|
@pisv which test suite is this? |
|
examples/api-tests/src/monaco-api.spec.js |
tsmaeder
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Before this fix, Monaco API KeybindingService.resolveKeybinding test was failing on macOS with
The
chord: falsewas removed from the expected object for other platforms as part of #13217.This fix removes it from the expected object for macOS.
How to test
Run
yarn teston macOS.Review checklist
Reminder for reviewers