Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message to mention UpstreamCodec filter #36367

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Error message to mention UpstreamCodec filter

7b12a1c
Select commit
Loading
Failed to load commit list.
Open

Error message to mention UpstreamCodec filter #36367

Error message to mention UpstreamCodec filter
7b12a1c
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/ASAN skipped Sep 27, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/36367/main@7b12a1c)

ravenblackx @ravenblackx 7b12a1c #36367 merge main@39851cd

Error message to mention UpstreamCodec filter

Commit Message: Error message to mention UpstreamCodec filter
Additional Description: The requirement described in #26138 doesn't seem to be mentioned in documentation, and even if it was I most likely wouldn't have seen it and probably neither would the person who filed the issue, so documenting the requirement in the failed validation error message seems a more practical solution.
Risk Level: Only changes an error message, so ~none.
Testing: Added unit test coverage (previously coverage was partial and from integration tests).
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Environment

Request variables

Key Value
ref fac6a9e
sha 7b12a1c
pr 36367
base-sha 39851cd
actor ravenblackx @ravenblackx
message Error message to mention UpstreamCodec filter...
started 1727465817.20699
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 32
patch 0
dev true