Default WITH_CRASHPAD to OFF instead of ON in CMake #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crashpad is only really useful in the context where multiple people are using the same build and remote debugging is desirable, i.e. distribution builds. For people building locally on their own machine, Crashpad is extremely unlikely to be helpful, and creating the environment where crashpad can actually be used involves the horror of Google's depot_tools and such... It seems more reasonable to make users explicitly opt *into* crashpad, rather than having to opt out, especially when the error message produced when trying to build with the past default settings was more likely to get users to try to install Crashpad to fix the problem rather than simply disabling it.
|
Note: I attempted to modify all of the existing documentation mentioning Crashpad to reflect this change, but it's possible I missed something somewhere. |
|
Hmm, maybe don't merge this yet, regarding the discussion in the dev Discord :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crashpad is only really useful in the context where multiple
people are using the same build and remote debugging is
desirable, i.e. distribution builds.
For people building locally on their own machine, Crashpad is
extremely unlikely to be helpful, and creating the environment
where crashpad can actually be used involves the horror of
Google's depot_tools and such...
It seems more reasonable to make users explicitly opt into
crashpad, rather than having to opt out, especially when the
error message produced when trying to build with the past
default settings was more likely to get users to try to
install Crashpad to fix the problem rather than simply
disabling it.