Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default WITH_CRASHPAD to OFF instead of ON in CMake #1324

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Default WITH_CRASHPAD to OFF instead of ON in CMake #1324

wants to merge 1 commit into from

Commits on Sep 28, 2024

  1. Default WITH_CRASHPAD to OFF instead of ON in CMake 

    Crashpad is only really useful in the context where multiple
 people are using the same build and remote debugging is
 desirable, i.e. distribution builds.

For people building locally on their own machine, Crashpad is
 extremely unlikely to be helpful, and creating the environment
 where crashpad can actually be used involves the horror of
 Google's depot_tools and such...

It seems more reasonable to make users explicitly opt *into*
 crashpad, rather than having to opt out, especially when the
 error message produced when trying to build with the past
 default settings was more likely to get users to try to
 install Crashpad to fix the problem rather than simply
 disabling it.
    @bluebandit21
    bluebandit21 committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    afd3791 View commit details
    Browse the repository at this point in the history