Add to support byte input stream back by file #10717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
force-pushed
the
refactor
branch
2 times, most recently
from
964c912
to
66881bd
Compare
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
force-pushed
the
refactor
branch
3 times, most recently
from
70226dc
to
4b9a815
Compare
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
force-pushed
the
refactor
branch
2 times, most recently
from
16c5812
to
d94f51f
Compare
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
changed the title
|
This pull request was exported from Phabricator. Differential Revision: D61148216 |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Aug 14, 2024
Summary: Pull Request resolved: facebookincubator#10717 Differential Revision: D61148216 Pulled By: xiaoxmeng
|
This pull request was exported from Phabricator. Differential Revision: D61148216 |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Aug 14, 2024
Summary: Pull Request resolved: facebookincubator#10717 Differential Revision: D61148216 Pulled By: xiaoxmeng
|
This pull request was exported from Phabricator. Differential Revision: D61148216 |
duanmeng
reviewed
Aug 14, 2024
| @@ -91,64 +94,29 @@ class OStreamOutputStream : public OutputStream { | |||
| std::ostream* out_; | |||
| }; | |||
|
|
|||
| /// Read-only stream over one or more byte buffers. | |||
| /// Read-only byte input stream interface. | |||
| class ByteInputStream { | |||
There was a problem hiding this comment.
Should we move this base class to the base folder as it has both memory stream subclass BufferInputStream and file stream subclass FileInputStream?
|
This pull request was exported from Phabricator. Differential Revision: D61148216 |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Aug 14, 2024
Summary: Current spill leverage SpillInputStream to handle the byte stream read from spilled file. SpillInputStream is a derived class from ByteInputStream and its implementation a bit hack as most of operations of ByteInputStream doesn't apply for SpillInputStream as we don't support backward seek on a file for now. It just works for now. It is better to split them and make a generic file based input stream which can be used in other cases as well. Pull Request resolved: facebookincubator#10717 Reviewed By: tanjialiang Differential Revision: D61148216 Pulled By: xiaoxmeng
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Aug 14, 2024
Summary: Current spill leverage SpillInputStream to handle the byte stream read from spilled file. SpillInputStream is a derived class from ByteInputStream and its implementation a bit hack as most of operations of ByteInputStream doesn't apply for SpillInputStream as we don't support backward seek on a file for now. It just works for now. It is better to split them and make a generic file based input stream which can be used in other cases as well. Pull Request resolved: facebookincubator#10717 Reviewed By: tanjialiang Differential Revision: D61148216 Pulled By: xiaoxmeng
|
This pull request was exported from Phabricator. Differential Revision: D61148216 |
duanmeng
approved these changes
Aug 14, 2024
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Aug 14, 2024
Summary: Current spill leverage SpillInputStream to handle the byte stream read from spilled file. SpillInputStream is a derived class from ByteInputStream and its implementation a bit hack as most of operations of ByteInputStream doesn't apply for SpillInputStream as we don't support backward seek on a file for now. It just works for now. It is better to split them and make a generic file based input stream which can be used in other cases as well. Pull Request resolved: facebookincubator#10717 Reviewed By: tanjialiang Differential Revision: D61148216 Pulled By: xiaoxmeng
|
This pull request was exported from Phabricator. Differential Revision: D61148216 |
Yuhta
approved these changes
Aug 14, 2024
| if (skipBytes == 0) { | ||
| return; | ||
| } | ||
| readNextRange(); |
There was a problem hiding this comment.
Do we really need to actually do the IO? Can we just manipulate fileOffset_ instead?
There was a problem hiding this comment.
yeah, I think we could. Let me see how to skip io in followup. Thanks!
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Aug 14, 2024
Summary: Current spill leverage SpillInputStream to handle the byte stream read from spilled file. SpillInputStream is a derived class from ByteInputStream and its implementation a bit hack as most of operations of ByteInputStream doesn't apply for SpillInputStream as we don't support backward seek on a file for now. It just works for now. It is better to split them and make a generic file based input stream which can be used in other cases as well. Pull Request resolved: facebookincubator#10717 Reviewed By: Yuhta, tanjialiang Differential Revision: D61148216 Pulled By: xiaoxmeng
|
This pull request was exported from Phabricator. Differential Revision: D61148216 |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Aug 14, 2024
Summary: Current spill leverage SpillInputStream to handle the byte stream read from spilled file. SpillInputStream is a derived class from ByteInputStream and its implementation a bit hack as most of operations of ByteInputStream doesn't apply for SpillInputStream as we don't support backward seek on a file for now. It just works for now. It is better to split them and make a generic file based input stream which can be used in other cases as well. With this change, ByteInputStream has two derived implementations: (1) BufferInputStream which support byte stream API back by a set of buffers; (2) FileInputStream which support byte stream API back by a sequential read file and doesn't support for backward seek. FileInputStream can be used by spill, tracing and file-based broadcast join etc. Pull Request resolved: facebookincubator#10717 Reviewed By: Yuhta, tanjialiang, ktsiam Differential Revision: D61148216 Pulled By: xiaoxmeng
|
This pull request was exported from Phabricator. Differential Revision: D61148216 |
|
This pull request was exported from Phabricator. Differential Revision: D61148216 |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Aug 14, 2024
Summary: Current spill leverage SpillInputStream to handle the byte stream read from spilled file. SpillInputStream is a derived class from ByteInputStream and its implementation a bit hack as most of operations of ByteInputStream doesn't apply for SpillInputStream as we don't support backward seek on a file for now. It just works for now. It is better to split them and make a generic file based input stream which can be used in other cases as well. With this change, ByteInputStream has two derived implementations: (1) BufferInputStream which support byte stream API back by a set of buffers; (2) FileInputStream which support byte stream API back by a sequential read file and doesn't support for backward seek. FileInputStream can be used by spill, tracing and file-based broadcast join etc. Pull Request resolved: facebookincubator#10717 Reviewed By: Yuhta, tanjialiang, ktsiam Differential Revision: D61148216 Pulled By: xiaoxmeng
Summary: Current spill leverage SpillInputStream to handle the byte stream read from spilled file. SpillInputStream is a derived class from ByteInputStream and its implementation a bit hack as most of operations of ByteInputStream doesn't apply for SpillInputStream as we don't support backward seek on a file for now. It just works for now. It is better to split them and make a generic file based input stream which can be used in other cases as well. With this change, ByteInputStream has two derived implementations: (1) BufferInputStream which support byte stream API back by a set of buffers; (2) FileInputStream which support byte stream API back by a sequential read file and doesn't support for backward seek. FileInputStream can be used by spill, tracing and file-based broadcast join etc. Pull Request resolved: facebookincubator#10717 Reviewed By: Yuhta, tanjialiang, ktsiam Differential Revision: D61148216 Pulled By: xiaoxmeng
|
This pull request was exported from Phabricator. Differential Revision: D61148216 |
|
@xiaoxmeng merged this pull request in 9523840. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current spill leverage SpillInputStream to handle the byte stream read from spilled file. SpillInputStream is a
derived class from ByteInputStream and its implementation a bit hack as most of operations of ByteInputStream
doesn't apply for SpillInputStream as we don't support backward seek on a file for now. It just works for now.
It is better to split them and make a generic file based input stream which can be used in other cases as well.