Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to support byte input stream back by file #10717

Closed
wants to merge 1 commit into from

Commits on Aug 14, 2024

  1. Add to support byte input stream back by file (facebookincubator#10717)

    Summary:
    Current spill leverage SpillInputStream to handle the byte stream read from spilled file. SpillInputStream is a
    derived class from ByteInputStream and its implementation a bit hack as most of operations of ByteInputStream
    doesn't apply for SpillInputStream as we don't support backward seek on a file for now. It just works for now.
    It is better to split them and make a generic file based input stream which can be used in other cases as well.
    
    With this change, ByteInputStream has two derived implementations:
    
    (1) BufferInputStream which support byte stream API back by a set of buffers;
    (2) FileInputStream which support byte stream API back by a sequential read file and doesn't support
    for backward seek.
    FileInputStream can be used by spill, tracing and file-based broadcast join etc.
    
    Pull Request resolved: facebookincubator#10717
    
    Reviewed By: Yuhta, tanjialiang, ktsiam
    
    Differential Revision: D61148216
    
    Pulled By: xiaoxmeng
    xiaoxmeng authored and facebook-github-bot committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    2449d86 View commit details
    Browse the repository at this point in the history