new(falco): add falco_libs.snaplen option, deprecate -S / --snaplen #3362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.40.0 |
LucaGuerra
force-pushed
the
new/falco_libs_snaplen_option
branch
2 times, most recently
from
3ed01ec
to
dcd1d05
Compare
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
LucaGuerra
force-pushed
the
new/falco_libs_snaplen_option
branch
from
dcd1d05
to
311626e
Compare
FedeDP
reviewed
Oct 1, 2024
| // | ||
| if(s.config->m_falco_libs_snaplen != 0) { | ||
| inspector->set_snaplen(s.config->m_falco_libs_snaplen); | ||
| } | ||
| if(s.options.snaplen != 0) { | ||
| inspector->set_snaplen(s.options.snaplen); |
There was a problem hiding this comment.
Do we want to add the `attention this is deprectated and will be removed in..." log here? Like this one: https://github.com/falcosecurity/falco/pull/3329/files#diff-e1e4257c43745e29751e72ffa753fd44ec931b07b1bec5035f4d1b04d061848cR100
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
As per title. This may be the last CLI option that we couldn't replicate in the falco config file.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: