style: code optimization

frappe · May 14, 2024 · e843683 · e843683
1 parent fa2b6c4
commit e843683
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/erpnext/accounts/doctype/journal_entry/journal_entry.py b/erpnext/accounts/doctype/journal_entry/journal_entry.py
@@ -453,12 +453,11 @@ def unlink_advance_entry_reference(self):
 
 	def unlink_asset_reference(self):
 		for d in self.get("accounts"):
-			root_type = frappe.get_value("Account", d.account, "root_type")
 			if (
 				self.voucher_type == "Depreciation Entry"
 				and d.reference_type == "Asset"
 				and d.reference_name
-				and root_type == "Expense"
+				and frappe.get_cached_value("Account", d.account, "root_type") == "Expense"
 				and d.debit
 			):
 				asset = frappe.get_doc("Asset", d.reference_name)