Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devices: add group for devices with only 6M flash #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grische
Copy link

@grische grische commented Nov 29, 2023

Currently, 6M flash is not sufficient to build the default firmware on some communities. This allows filtering for those devices.

@grische grische force-pushed the feature/filter-6m-flash-devices branch from 01074d5 to 91f7c35 Compare November 29, 2023 11:40
@grische grische changed the title devices: add group with devices with only 6M flash devices: add group for devices with only 6M flash Nov 29, 2023
@grische grische force-pushed the feature/filter-6m-flash-devices branch from 91f7c35 to 02e8dd0 Compare December 7, 2023 20:05
Currently, 6M flash is not sufficient to build the default firmware on some
communities. This allows filtering for those devices.
@grische
Copy link
Author

grische commented Dec 7, 2023

As discussed here, adding the DIR-825 back to the recommended list: freifunk/meshviewer#75 (comment)

@herbetom
Copy link
Member

Problem with adding a new category is that devices will be always hidden for existing Users without them adjusting their config and it isn't a opt-in. Those models won't even be selectable via the "only show recomended" feature (if enabled) without enabling them first.

Not all of those devices will be dropped in the upcoming Gluon v2023.2. I haven't checked but would therefore suspect not all of them share the same exact limit.

I would probably prefer allowing 6m devices beeing selectable via some major change that completly rethinks how devices are added. Or having some "don't advertise"/"hide devices" list via the config to allow communities to hide what they thing should be hidden.

But I haven't thought it all through and I don't want to be nailed down to thinking those would be good approaches 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants