Add deprecation notice for 6M flash devices #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
blocktrron
reviewed
Dec 4, 2023
lib/config_default.js
Outdated
| @@ -200,9 +200,21 @@ export const config = { | |||
| "AP121U", | |||
| "D-Link DIR-615", | |||
| "D-Link DIR-615 D", | |||
| "D-Link DIR-825", | |||
There was a problem hiding this comment.
Why? This has been fixed and the limit only applies to factory installations (Which are removed from Gluon)
There was a problem hiding this comment.
I went through the list of targets of the latest release and it was marked as only 6M flash
https://github.com/freifunk-gluon/gluon/blob/7feebe96a6b93d567bd342ffd01abcb3022383c5/targets/ath79-generic#L124
There was a problem hiding this comment.
This is outdated then, see openwrt/openwrt@aca8bb5
grische
force-pushed
the
feature/filter-6m-flash-devices
branch
from
1654ffe
to
7b6dae6
Compare
|
@blocktrron can we merge this PR? |
3 tasks
|
@grische please rebase |
|
I prefer #81 |
|
Let's focus on this PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
6M flash devices are not future-proof and have been dropped by some communities already.
Motivation and Context
freifunk-darmstadt/gluon-firmware-selector#159
How Has This Been Tested?
N/A
Checklist: