Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example in readme #24

Merged
merged 1 commit into from
Nov 23, 2016
Merged

Fix example in readme #24

merged 1 commit into from
Nov 23, 2016

Conversation

oleksii-dmytrenko
Copy link
Contributor

example from readme fails with errors:

  1. Declaration of class@anonymous::onError(int $code, Icicle\Socket\Socket $socket) must be compatible with Icicle\Http\Server\RequestHandler::onError($code, Icicle\Socket\Socket $socket)
  2. A Icicle\Http\Message\Response object was not returned from :onRequest().

Fix example in readme
a03a2d2 
example from readme fails with errors:
1. Declaration of class@anonymous::onError(int $code, Icicle\Socket\Socket $socket) must be compatible with Icicle\Http\Server\RequestHandler::onError($code, Icicle\Socket\Socket $socket)
2. A Icicle\Http\Message\Response object was not returned from :onRequest().
@oleksii-dmytrenko
Copy link
Contributor Author

#20
#21

@coveralls
Copy link

Coverage Status

Coverage remained the same at 58.326% when pulling a03a2d2 on italeks:patch-1 into efd477d on icicleio:master.

@sagebind
Copy link

Thanks, looks like an oversight when the master branch was updated to a PHP 7+ API.

@sagebind sagebind merged commit 13c5b45 into icicleio:master Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagebind sagebind sagebind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksii-dmytrenko @coveralls @sagebind