New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example in readme #24

Merged

sagebind merged 1 commit into icicleio:master from oleksii-dmytrenko:patch-1

Nov 23, 2016

Commits on Nov 23, 2016

Fix example in readme

example from readme fails with errors:
1. Declaration of class@anonymous::onError(int $code, Icicle\Socket\Socket $socket) must be compatible with Icicle\Http\Server\RequestHandler::onError($code, Icicle\Socket\Socket $socket)
2. A Icicle\Http\Message\Response object was not returned from :onRequest().

Oleksii authored Nov 23, 2016