Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: directory creation on pulling data #10580

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sssilvar
Copy link

@sssilvar sssilvar commented Oct 3, 2024

Closes #10579

@@ -571,7 +571,7 @@ def _get( # noqa: C901, PLR0912

os.makedirs(lpath, exist_ok=True)
for d in _dirs:
os.mkdir(d)
os.mkdir(d, exist_ok=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no exist_ok=True in os.mkdir. That is in os.makedirs.

This should either be:

Suggested change
os.mkdir(d, exist_ok=True)
try:
os.mkdir(d)
except OSError:
if not os.path.isdir(d):
raise

or,

Suggested change
os.mkdir(d, exist_ok=True)
os.makedirs(d, exist_ok=True)

I'd prefer the first one as makedirs calls os.path.exists() on all the parents of the path.

@skshetry
Copy link
Member

skshetry commented Oct 4, 2024

Hi, thank you for contributing. The tests and the linter is failing, please take a look at https://dvc.org/doc/contributing/core on how to run tests and fix linter issues. Please feel free to ask if you need any help. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pull with Python API: raises error when directory exists during data pull with python api
2 participants