Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: directory creation on pulling data #10580

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: directory creation on pulling data #10580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dvc/fs/dvc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ def _get( # noqa: C901, PLR0912

os.makedirs(lpath, exist_ok=True)
for d in _dirs:
os.mkdir(d)
os.mkdir(d, exist_ok=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no exist_ok=True in os.mkdir. That is in os.makedirs.

This should either be:

Suggested change
os.mkdir(d, exist_ok=True)
try:
os.mkdir(d)
except OSError:
if not os.path.isdir(d):
raise

or,

Suggested change
os.mkdir(d, exist_ok=True)
os.makedirs(d, exist_ok=True)

I'd prefer the first one as makedirs calls os.path.exists() on all the parents of the path.


def get_file(arg: tuple[FileSystem, tuple[str, str, Optional[dict]]]):
fs, (src, dest, info) = arg
Expand Down
Loading